Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add off sdk #1151

Merged
merged 2 commits into from
Aug 7, 2023
Merged

refactor: add off sdk #1151

merged 2 commits into from
Aug 7, 2023

Conversation

raphael0202
Copy link
Collaborator

@raphael0202 raphael0202 commented Jul 24, 2023

Use OFF SDK to replace part of Robotoff codebase.

@raphael0202 raphael0202 marked this pull request as ready for review August 7, 2023 11:42
@raphael0202 raphael0202 requested a review from a team as a code owner August 7, 2023 11:42
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1151 (d504219) into master (58acf39) will decrease coverage by 0.62%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
- Coverage   57.06%   56.45%   -0.62%     
==========================================
  Files          79       79              
  Lines        8362     8198     -164     
==========================================
- Hits         4772     4628     -144     
+ Misses       3590     3570      -20     
Files Changed Coverage Δ
robotoff/insights/importer.py 83.70% <ø> (ø)
robotoff/off.py 30.53% <100.00%> (-1.51%) ⬇️
...ral/keras_category_classifier_3_0/preprocessing.py 85.96% <100.00%> (ø)
robotoff/taxonomy.py 73.21% <100.00%> (-11.48%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raphael0202 raphael0202 merged commit 9c2d1c6 into master Aug 7, 2023
10 checks passed
@raphael0202 raphael0202 deleted the add-off-sdk branch August 7, 2023 12:20
@alexgarel
Copy link
Member

Kudos for this move @raphael0202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants